Skip to content

Conversation

@jimmyw
Copy link
Contributor

@jimmyw jimmyw commented Oct 30, 2025

Description

Over a year ago i was hunting heap fragmentation in out BESS product. I noticed there was a lot of 4 bytes allocations, that really allocates space for one memory pointer. This is very inefficient.
On top of this, 5.3 that we where using at the time, but this 4 byte allocation in external ram, but the queue or semaphore referring to was placed in internal ram, causing a big performance issue. I think that very problem was sorted out now, by using mem_malloc but the other optimizations that i added that have been running flawlessly in our production for over a year is added here in my PR.

This avoids duplicated malloc, on a congested code path. Avoids
additional heap overhead, increases speed and lowers memory usage.
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello jimmyw, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against b410410

cursor[bot]

This comment was marked as outdated.

@jimmyw jimmyw force-pushed the master branch 2 times, most recently from 6f55218 to b410410 Compare October 30, 2025 11:38
@jimmyw jimmyw changed the title LWIP memory/performanche heap optimization fix(lwip): LWIP memory/performanche heap optimization Oct 30, 2025
@github-actions github-actions bot changed the title fix(lwip): LWIP memory/performanche heap optimization fix(lwip): LWIP memory/performanche heap optimization (IDFGH-16710) Oct 30, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Opened Issue is new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants